test: switch from jest to vitest #10412
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
JammingBen
force-pushed
the
vitest
branch
2 times, most recently
from
c20c8f2 to
29c144d
Compare
tests/unit/config/jest.overrides.ts
Outdated
There was a problem hiding this comment.
I'm not sure ... doesn't this code take care we're logging vue warnings to the console? Do we have that in vitest ootb or should we keep/port this?
There was a problem hiding this comment.
Good catch, I don't know to be honest. Definitely something we should check.
There was a problem hiding this comment.
As you correctly assumed that's because the corresponding test is being skipped and never actually ran once with vitest.
| // region: { enabled: false } | ||
| // } | ||
| // }) | ||
| // ).toHaveNoViolations() |
There was a problem hiding this comment.
Why is this skipped?
Is this the reason the snapshot is gone? Although this test was skipped before already ...
Can't we fix it or add at least a comment what fails?
There was a problem hiding this comment.
There is a comment already, this test has always been flaky and I don't know why and how to fix it 🤷
There was a problem hiding this comment.
Oh I thought we don't use axe anymore... if I remember correctly this was just a quick test / use case for automated accessibility tests. Since we didn't follow up I'd say completely get rid of it for now (here and in OcTable).
| expect(catchFn).toHaveBeenCalledWith(expect.any(mockAxios.Cancel)) | ||
| done() | ||
| }) | ||
| }) |
There was a problem hiding this comment.
Added removal of HttpClient to the followup tasks... was easier for now to just remove the test than to port it. The function is unused anyhow...
| expect(clientService.owncloudSdk.shares.getShares).toHaveBeenCalledTimes(4) | ||
|
|
||
| // FIXME: pqueue makes issues?! | ||
| // expect(clientService.owncloudSdk.shares.getShares).toHaveBeenCalledTimes(4) |
There was a problem hiding this comment.
uaaaaaaarghs - what do we make out of this?
There was a problem hiding this comment.
We didn't find a solution 😅 That's the only place where this causes issues...
packages/web-pkg/tests/unit/composables/actions/useOpenWithDefaultApp.spec.ts
Outdated
Show resolved
Hide resolved
packages/web-pkg/tests/unit/composables/actions/files/useFileActionsCreateLink.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Would it be potentially better to use fake timers than sleeping 600ms?
Not that it matters thaaaat much in this single test but in theory...
There was a problem hiding this comment.
I tried it, but it didn't work for some reason. The docs are mentioning only setTimeout and setInterval... maybe we can't use it for lodash's debounce.
|
Description
Removes
jestin favour ofvitestfor our unit test suite. The API remains nearly unchanged (expect for thatjestnow becamevi).Unfortunately we lose our nice snapshot formatter. We have to see if there is some äquivalent for vitest.
Possibly/hopefully fixes #10380.
Types of changes
Followup Tasks